Treat punctuation as optional for org name conviction checks #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/RUBY-741 This fixes an issue spotted in QA. Punctuation should be treated as optional when matching organisation names - for example, if a user enters "Waste Not (Want Not) UK" that should still match a record called "Waste Not Want Not UK".
Cruikshanks
previously approved these changes
Nov 20, 2019
| @@ -88,15 +88,34 @@ def self.matching_organisations(name:, company_no: nil) | |||
| private_class_method def self.org_name_search_term(term) | |||
| return if term.blank? | |||
|
|
|||
| # Trim trailing full stops | |||
| term_without_trailing_full_stops = term.gsub(/\.$/, "") | |||
| # The steps for processing the org name must be done in this order: | |||
There was a problem hiding this comment.
Could I have all my code written like this, please? I might then finally have a clue what everything is doing! ❤️ 😁
cintamani
previously approved these changes
Nov 20, 2019
| end | ||
|
|
||
| private_class_method def self.term_with_optional_punctuation(term) | ||
| # These are characters we want to treat as optional |
There was a problem hiding this comment.
Shall we reflect this in the variable's name? Like: optional_chars instead of punctuation_chars :)
There was a problem hiding this comment.
That probably makes sense. I got what was going on without issue so didn't spot this, but now that you highlight it, I see why.
There was a problem hiding this comment.
@cintamani Good shout! Updated: 4c1852a
irisfaraway
dismissed stale reviews from cintamani and Cruikshanks
via
4c1852a
Cruikshanks
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/RUBY-741
This fixes an issue spotted in QA. Punctuation should be treated as optional when matching organisation names - for example, if a user enters "Waste Not (Want Not) UK" that should still match a record called "Waste Not Want Not UK".