Add service that generates Base(58) secure tokens #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In WEX and FRAE we have relied on using [HasSecureToken](https://github.com/robertomiranda/has_secure_token) to generate unique random tokens of a fixed length in the objects we create. We have a need to unqiuely identify a record, but cannot use its ID because it also has to be something 'unguessable'. HasSecureToken works for WEX and FRAE because it is designed to work with ActiveRecord models. WCR on the overhand uses MongoDb, which means we can't use it. So instead, we've copied it wholesale into our project as a service we can call when we need to generate a token. Thanks @robertomiranda 馃榿!
cintamani
previously approved these changes
Dec 5, 2019
spec/services/waste_carriers_engine/secure_token_service_spec.rb
Outdated
Show resolved
Hide resolved
Because whitespace slows @cintamini down! Co-Authored-By: cintamani <cintamani.puddu@gmail.com>
Because white space slows @cintamani down! Co-Authored-By: cintamani <cintamani.puddu@gmail.com>
cintamani
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WEX and FRAE we have relied on using HasSecureToken to generate unique random tokens of a fixed length in the objects we create.
We have a need to unqiuely identify a record, but cannot use its ID because it also has to be something 'unguessable'.
HasSecureToken works for WEX and FRAE because it is designed to work with ActiveRecord models. WCR on the overhand uses MongoDb, which means we can't use it.
So instead, we've copied it wholesale into our project as a service we can call when we need to generate a token. Thanks @robertomiranda 馃榿!