Update BaseForm to work with Registrations #597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The back office has a few forms that inherit from BaseForm but supply a registration in place of a transient_registration. However, as registrations don't have tokens, this caused errors. This PR updates the BaseForm to only deal with tokens when the object in question is actually a TransientRegistration.
(We should arguably consider renaming
transient_registration
toresource
or something like that, but I think that's a bigger job for another time!)