Fix errors in pluralisation and remove dots #616
Conversation
From: https://eaflood.atlassian.net/browse/RUBY-814 QA have found out some inconsistencies with the use of dots and pluralization of order descriptions. This PR includes fixes for both. Instructions will be give to deal with legacy data during testing. There is also a fix about the email address used in the wireframe, which didn't match what is currently sent out to the user.
| @@ -4,26 +4,26 @@ en: | |||
| send_order_completed_email: | |||
| subject: "We’re printing your waste carriers registration cards" | |||
| dear: "Dear %{full_name}" | |||
| heading: "We’re printing your waste carriers registration cards. They should arrive within 10 working days." | |||
| heading: "We’re printing your waste carriers registration cards. They should arrive within 10 working days" | |||
There was a problem hiding this comment.
I have spoken with @andrewhick and confirmed this. If we are trying to ensure the pluralisation is correct for copy cards, then this should include the subject and heading in the email as well, not just the back office UI.
And as this PR is focused on fixing these issues, I thought it would make sense to make those changes here rather than as subsequent one. However, if you don't agree I'm happy to approve. We'll just need another PR for handling pluralisation in the email content.
There was a problem hiding this comment.
Since doing that requires to add a quantity field to the OrderItem object, I think I will open a different PR :)
There was a problem hiding this comment.
Agree with @cintamani . We need to make structural changes to the registration to handle this, so is best done in a separate PR.
From: https://eaflood.atlassian.net/browse/RUBY-814
QA have found out some inconsistencies with the use of dots and pluralization of order descriptions. This PR includes fixes for both. Instructions will be give to deal with legacy data during testing.
There is also a fix about the email address used in the wireframe, which didn't match what is currently sent out to the user.