Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch airbrake mgmt to defra-ruby-alert #657

Merged
merged 3 commits into from
Feb 7, 2020

Commits on Feb 4, 2020

  1. Switch airbrake mgmt to defra-ruby-alert

    Whilst working on an issue for the [Flood Risk Activity Exemptions service](https://github.com/DEFRA/ruby-services-team/tree/master/services/frae) we came across an [issue](DEFRA/flood-risk-engine#312) with Airbrake.
    
    We wanted to add a new Rake task, and we wanted to apply our new pattern of ensuring Airbrake is closed when the task exits to ensure any errors are reported. The problem was due to the age of the Airbrake gem being used this caused an error in FRAE we hadn't seen in WEX and WCR.
    
    So for reasons outlined in [FRAE PR 312](DEFRA/flood-risk-engine#312) we came up with [defra-ruby-alert](https://github.com/DEFRA/defra-ruby-alert). The idea is going forward this will provide a single interface for configuring Airbrake and ensure the pattern of making sure all exceptions are reported before an app closes is applied consistently in all scenarios.
    
    These changes are the first step in switching the WCR service to using it.
    Cruikshanks committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    9efdf7b View commit details
    Browse the repository at this point in the history
  2. Remove Airbrake, add defra-ruby-alert

    This includes updating the engine config to cover defra_ruby_alert.
    Cruikshanks committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    a531943 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2020

  1. Configuration menu
    Copy the full SHA
    55bbfe3 View commit details
    Browse the repository at this point in the history