Move and rename renewing registration workflow specs #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a change of directory name from "workflow_states" to the more specific "renewing_registration_workflow", and then taking "transient_registration_" off the start of all the spec files. This brings the specs more into line with the other workflow specs, which didn't exist when they were first created. There's a lot more we can do to improve these specs, but I'm isolating renaming in this PR to preserve the history as much as possible.
Cruikshanks
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a change of directory name from "workflow_states" to the more specific "renewing_registration_workflow", and then taking "transient_registration_" off the start of all the spec files. This brings the specs more into line with the other workflow specs, which didn't exist when they were first created.
There's a lot more we can do to improve these specs, but I'm isolating renaming in this PR to preserve the history as much as possible.