Remove = in Travis rubocop command #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been going through the repos updating our Travis config to use a rubocop command that has multiple formatters. As part of that work @irisfaraway pointed out that there is no need to have the = sign in the command. This is confirmed by the examples she found https://github.com/rubocop-hq/rubocop/blob/master/manual/formatters.md. So the version we have been using in the other repos doesn't have the = sign and this change updates this project to match.
irisfaraway
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been going through the repos updating our Travis config to use a rubocop command that has multiple formatters. As part of that work @irisfaraway pointed out that there is no need to have the = sign in the command. This is confirmed by the examples she found https://github.com/rubocop-hq/rubocop/blob/master/manual/formatters.md.
So the version we have been using in the other repos doesn't have the = sign and this change updates this project to match.