Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externalise go back and create overrides to concerns #836

Merged
merged 2 commits into from
May 12, 2020
Merged

Externalise go back and create overrides to concerns #836

merged 2 commits into from
May 12, 2020

Conversation

cintamani
Copy link
Contributor

@cintamani cintamani added the housekeeping Changes such as refactoring label May 12, 2020
@cintamani cintamani self-assigned this May 12, 2020
irisfaraway
irisfaraway approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@irisfaraway irisfaraway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@cintamani
Copy link
Contributor Author

Sonar cloud style. of comments doesn't match ours :D @irisfaraway can you. merge it for me, please? :)

@irisfaraway irisfaraway merged commit 78414cc into master May 12, 2020
@irisfaraway irisfaraway deleted the issues/55 branch May 12, 2020 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irisfaraway irisfaraway irisfaraway approved these changes

@Cruikshanks Cruikshanks Awaiting requested review from Cruikshanks

Assignees

@cintamani cintamani

Labels
housekeeping Changes such as refactoring
Projects
None yet
Milestone
No milestone
2 participants
@cintamani @irisfaraway