Remove extra logging and fix order of events

[cintamani]

This removes some unnecessary error raised, fix an issue with the order of events and adds an extra check before deciding if a registration can be activated or not.

[Cruikshanks]

No issue with the tweaks to the order of things. Plus agree we can drop throwing the exceptions when payment is outstanding or a conviction check is required.

But I think it would still be useful to at least log when we have tried to activate a registration and it has failed. How would you feel about instead of raising an exception we record something in the log instead?

[cintamani]

If can_be_completed? is false we return rather than raise an error, and this is fine because any finance operation (and not only finance operation) will run that code without having a concern if the registration can actually be activated. That is the unnecessary logging I am removing.

If can_be_completed? is true, then we are saying "this registration is into a state we can activate". Given that an error. with sending an email is already custom logged, we are not worried about that. Other things that can go wrong are going to raise an error that will end up in airbrake for us to see as we are using ! methods to activate the registration. Hence, I don't think we need more logging.

Unless I didn't get what you meant, of course, as always XD

[Cruikshanks]

I was on the fence. I have been persuaded. Hit the button! 😁