Remove link to certificate from renewal complete #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/RUBY-1154 The link in the page takes you to the frontend where if you are not signed in, you then have to in order to access the link. We don't provide this link on the new 'new registration' done page. It is also our intention to remove accounts in the near future so access to this will be removed anyway. So this change is just about removing the link in the page to make it consistent with the new registration complete page, and with our future intentions.
Cruikshanks
deleted the
remove-certificate-link-from-renewal-complete-page
branch
Cruikshanks
added a commit
to DEFRA/waste-carriers-front-office
that referenced
this pull request
Jul 14, 2020
https://eaflood.atlassian.net/browse/RUBY-1154 The link in the page takes you to the frontend where if you are not signed in, you then have to in order to access the link. We don't provide this link on the new 'new registration' done page. It is also our intention to remove accounts in the near future so access to this will be removed anyway. So this change is just about removing the link in the page to make it consistent with the new registration complete page, and with our future intentions. The change was actually done in the engine as [PR #887](DEFRA/waste-carriers-engine#887). We are just updating the version of the engine to bring the change into the front-office. <details><summary>Before</summary>  </details> <details><summary>After</summary>  </details>
Cruikshanks
added a commit
to DEFRA/waste-carriers-back-office
that referenced
this pull request
Jul 14, 2020
https://eaflood.atlassian.net/browse/RUBY-1154 The link in the page takes you to the frontend where if you are not signed in, you then have to in order to access the link. We don't provide this link on the new 'new registration' done page. It is also our intention to remove accounts in the near future so access to this will be removed anyway. So this change is just about removing the link in the page to make it consistent with the new registration complete page, and with our future intentions. The change was actually done in the engine as [PR #887](DEFRA/waste-carriers-engine#887). We are just updating the version of the engine to bring the change into the back-office. <details><summary>Before</summary>  </details> <details><summary>After</summary>  </details>
Cruikshanks
added a commit
to DEFRA/waste-carriers-front-office
that referenced
this pull request
Jul 14, 2020
https://eaflood.atlassian.net/browse/RUBY-1154 The link in the page takes you to the frontend where if you are not signed in, you then have to in order to access the link. We don't provide this link on the new 'new registration' done page. It is also our intention to remove accounts in the near future so access to this will be removed anyway. So this change is just about removing the link in the page to make it consistent with the new registration complete page, and with our future intentions. The change was actually done in the engine as [PR #887](DEFRA/waste-carriers-engine#887). We are just updating the version of the engine to bring the change into the front-office.
Cruikshanks
added a commit
to DEFRA/waste-carriers-back-office
that referenced
this pull request
Jul 14, 2020
https://eaflood.atlassian.net/browse/RUBY-1154 The link in the page takes you to the frontend where if you are not signed in, you then have to in order to access the link. We don't provide this link on the new 'new registration' done page. It is also our intention to remove accounts in the near future so access to this will be removed anyway. So this change is just about removing the link in the page to make it consistent with the new registration complete page, and with our future intentions. The change was actually done in the engine as [PR #887](DEFRA/waste-carriers-engine#887). We are just updating the version of the engine to bring the change into the back-office.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/RUBY-1154
The link in the page takes you to the frontend where if you are not signed in, you then have to in order to access the link. We don't provide this link on the new 'new registration' done page. It is also our intention to remove accounts in the near future so access to this will be removed anyway.
So this change is just about removing the link in the page to make it consistent with the new registration complete page, and with our future intentions.
Before
After