Tweak key people validation handling and heading #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are following the QA review. The bulk of the changes are about how we handle validation messages. This commit reduces the number of validation errors which a user can get for submitting the form without all the required information. Previously a totally blank form would trigger about 6 different messages - now it should just be one. Date validation errors have also been simplified so if all fields are missing, we only display a single message. We also only check that the complete date is a valid date once we've validated the individual fields to reduce the number of errors users get. Also changed the heading text for overseas users.
irisfaraway
requested review from
Cruikshanks
and removed request for
Cruikshanks
irisfaraway
changed the title
|
@Cruikshanks Would you mind having a quick look at this when you've got the time? I had to make some fairly big changes to how this form is validated (added another custom validator, which then calls a second custom validator) so it could probably benefit from a second pair of eyes. |
Cruikshanks
approved these changes
Mar 5, 2018
| return unless field_is_integer?(record, type, field) | ||
| def all_fields_empty?(record) | ||
| fields = [record.dob_day, record.dob_month, record.dob_year].compact | ||
| return false if fields.any? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are following the QA review.
The bulk of the changes are about how we handle validation messages. This commit reduces the number of validation errors which a user can get at one time:
Also changed the heading text for overseas users to match the wireframe.