Mount the WasteCarriersEngine and start configuration #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to move a lot of stuff over from the renewals app, so we'll start with some initializers. Current status is the app looks right and mounts the engine, but can't connect to databases. This is a safety commit before rebuilding Vagrant box to check if this is the cause.
Copy over the secure headers initialiser. Also specify that the list of registrations should be the root for now. This is to match the prior behaviour of the renewals app.
After making some changes to the engine, we no longer need this.
irisfaraway
force-pushed
the
feature/implement-engine
branch
from
c10a6e6
to
3bb9c8c
Compare
For some reason, calling WasteCarriersEngine::VERSION worked when using a local version of the gem, but not when pulling it from GitHub. We can set the version in an initialiser to get around this.
This used to be part of the renewals app before it became an engine. However, the script doesn't work as part of the engine so it's time to relocate it.
irisfaraway
force-pushed
the
feature/implement-engine
branch
from
84c84a4
to
c3c0df3
Compare
We've merged the engine setup into master of waste-carriers-renewals now.
Cruikshanks
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WC-188
We are moving the renewals journey into an engine: DEFRA/waste-carriers-engine#203
This means we can mount the engine in the front office (and later in the back office).
From the user's perspective, there should be no change between running the pre-engine renewals app and running the new front office with the engine.