Add bulk export functionality to DefraRuby::Exporters #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/RUBY-68 The second half of the functionality for the DefraRuby Exporters library is to add bulk exports. This is the feature to generate CSV files containing all of the registration exemptions data in the database.
eminnett
force-pushed
the
add-bulk-export-functionality
branch
from
81bdde1
to
8ca99b6
Compare
|
The force push was to fix a typo in the commit message. |
Cruikshanks
requested changes
Mar 29, 2019
There was a problem hiding this comment.
Most of the feedback is personal opinion so open for discussion.
The one overarching thing I'd say is if I'd have taken the time to understand how complex wrangling the date ranges would be and how much code it would add, I might have gone for something more hacky and far less refined as our starter for ten. But that's a lesson for me, and the upside is we should be able to handle anything thrown at us now!
spec/defra_ruby/exporters/registration_bulk_export_report_spec.rb
Outdated
Show resolved
Hide resolved
added 5 commits
March 29, 2019 10:46
Cruikshanks
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/RUBY-68
The second half of the functionality for the DefraRuby::Exporters library is to add bulk exports. This is the feature to generate CSV files containing all of the registration exemptions data in the database.