Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support last email cache feature #120

Merged
merged 2 commits into from
Apr 1, 2019

Conversation

Cruikshanks
Copy link
Member

https://eaflood.atlassian.net/browse/RUBY-256

WEX engine PR 112 added the ability to see the details of the last email sent as JSON.

However to enable it in the app we need to update the engine to the lastest, and then include the configuration in the engine initializer.

This change makes the necessary changes to the app to support using this feature in our non-production environments.

https://eaflood.atlassian.net/browse/RUBY-256

[WEX engine PR 112](DEFRA/waste-exemptions-engine#112) added the ability to see the details of the last email sent as JSON.

However to enable it in the app we need to update the engine to the lastest, and then include the configuration in the engine initializer.

This change makes the necessary changes to the app to support using this feature in our non-production environments.
@Cruikshanks Cruikshanks added the enhancement New feature or request label Apr 1, 2019
@Cruikshanks Cruikshanks self-assigned this Apr 1, 2019
Copy link
Member

@irisfaraway irisfaraway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think there may be a copy-paste issue...

config/initializers/waste_exemptions_engine.rb Outdated Show resolved Hide resolved
Copy link
Member

@irisfaraway irisfaraway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@Cruikshanks Cruikshanks merged commit 3660f3d into master Apr 1, 2019
@Cruikshanks Cruikshanks deleted the implement-last-email-support branch April 1, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants