Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose confirmation letter #130

Merged
merged 23 commits into from
Apr 9, 2019
Merged

Expose confirmation letter #130

merged 23 commits into from
Apr 9, 2019

Conversation

eminnett
Copy link
Contributor

@eminnett eminnett commented Apr 9, 2019

https://eaflood.atlassian.net/browse/RUBY-66

Back-office need to be able to generate the confirmation letter PDF so it can be printed and mailed to customers who require AD or don't have an email address.

Acceptance Criteria:

  • logged-in users can view the confirmation letter for a registration (not a transient one)
  • the letter is a PDF
  • the letter looks like the letter from the old WEX back office
  • the correct information is displayed on the letter
  • we use the existing content for now, but will suggest any changes for the future

@eminnett eminnett self-assigned this Apr 9, 2019
@eminnett eminnett added the enhancement New feature or request label Apr 9, 2019
irisfaraway
irisfaraway requested changes Apr 9, 2019
View reviewed changes
Copy link
Member

@irisfaraway irisfaraway left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things. I tried to use suggestions as much as possible so you can hopefully hit them quickly!

There are a lot of missing newlines in non-Ruby files as well.

app/presenters/confirmation_letter_presenter.rb Outdated Show resolved Hide resolved
app/presenters/confirmation_letter_presenter.rb Show resolved Hide resolved
app/assets/stylesheets/confirmation_letter.css Show resolved Hide resolved
app/views/confirmation_letter/show.html.erb Outdated Show resolved Hide resolved
app/views/confirmation_letter/show.html.erb Outdated Show resolved Hide resolved
app/views/confirmation_letter/show.html.erb Outdated Show resolved Hide resolved
app/views/confirmation_letter/show.html.erb Outdated Show resolved Hide resolved
app/views/confirmation_letter/show.html.erb Outdated Show resolved Hide resolved
app/views/confirmation_letter/show.html.erb Outdated Show resolved Hide resolved
irisfaraway and others added 4 commits April 9, 2019 13:56
@irisfaraway
Add missing trailing backslashes in the view
274cdf7 
Co-Authored-By: eminnett <ed@methodic.io>
@irisfaraway
Refactor view conditional blocks
0b578b3 
Co-Authored-By: eminnett <ed@methodic.io>
@irisfaraway
Fix incorrect translation key
e0bb9c0 
Co-Authored-By: eminnett <ed@methodic.io>
Fix business_details translation key mappings
235b1ab
@eminnett eminnett merged commit 5761434 into master Apr 9, 2019
@eminnett eminnett deleted the expose-confirmation-letter branch April 9, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irisfaraway irisfaraway irisfaraway approved these changes

Assignees

@eminnett eminnett

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@eminnett @irisfaraway