-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display regs on dashboard in a useful way #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/RUBY-59 This PR covers the display and styling of registrations on the dashboard. Each registration should have key information clearly displayed, as well as what actions can be taken.
This commit adds the business name, reference number, location information and names of relevant people. It also lists all actions (including ones which may not be available) but these don't link to anything yet. Following the design of the new waste-carriers-front-office dashboard as this is the most recent one which has had designer input.
…/waste-exemptions-back-office-ta into feature/display-regs-on-db
If there's no site address, deal with that gracefully instead of breaking. (This shouldn't really happen with registrations but is a possibility for new transient_registrations.)
Think this is ready for review, with the caveats that:
|
Cruikshanks
approved these changes
Feb 1, 2019
irisfaraway
added a commit
that referenced
this pull request
Feb 7, 2019
The pagination links were accidentally removed in #16 - this commit adds them back.
irisfaraway
added a commit
that referenced
this pull request
Feb 8, 2019
The pagination links were accidentally removed in #16 - this commit adds them back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/RUBY-59
This PR covers the display and styling of registrations on the dashboard. Each registration should have key information clearly displayed, as well as what actions can be taken.