Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix defra_ruby_aws gem name #235

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Fix defra_ruby_aws gem name #235

merged 1 commit into from
Jun 25, 2019

Conversation

irisfaraway
Copy link
Member

We renamed this to use snake case instead of kebab case.

Resolves https://github.com/DEFRA/waste-exemptions-back-office-ta/issues/232

@irisfaraway
Fix defra_ruby_aws gem name
889a5ef 
We renamed this to use snake case instead of kebab case.

Resolves https://github.com/DEFRA/waste-exemptions-back-office-ta/issues/232
@irisfaraway irisfaraway added the housekeeping Refactoring, tidying up or other work which supports the code label Jun 24, 2019
@irisfaraway irisfaraway self-assigned this Jun 24, 2019
cintamani
cintamani approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@cintamani cintamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers :D

@irisfaraway irisfaraway merged commit 6d60f5b into master Jun 25, 2019
@irisfaraway irisfaraway deleted the fix/gem-name branch June 25, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cintamani cintamani cintamani approved these changes

@Cruikshanks Cruikshanks Awaiting requested review from Cruikshanks

Assignees

@irisfaraway irisfaraway

Labels
housekeeping Refactoring, tidying up or other work which supports the code
Projects
None yet
Milestone
No milestone
2 participants
@irisfaraway @cintamani