Schedule the registration exemptions expiry job to run daily #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://eaflood.atlassian.net/browse/RUBY-413 This adds a rake task and a service object to deal with setting the status of a registration exemption to expired when it is in an active status and the expire date is in the past. After talking about expiring on the day of expire or the day before, we have decided that the registration is considered expired after the date have passed, hence this include a fix on our logic for "not_expired" registrations too. One more thing part of this PR is the definition of the RegistrationExemption table name which allow us to use the AASM default defined scopes.
From https://eaflood.atlassian.net/browse/RUBY-413 Add configuration and scheduling of the registration exemptions expiry job
cintamani
changed the title
cintamani
changed the title
irisfaraway
previously approved these changes
Jul 5, 2019
Cruikshanks
requested changes
Jul 5, 2019
There was a problem hiding this comment.
This also means I'll need to go in and update .env.example and our tests to ensure they follow the same principle for the other jobs 😩 . But as there is no reason to be different in this case we might as well set the time to be what it will actually be unless there is a reason to be different.
|
@irisfaraway One for our dev meetings I think about how we define what needs a feature flag. But I'd like to keep them to a minimum. So I'm currently going with
In the case of this we want it running asap, and everything is good to go, so I don't think it needs a feature flag. |
Co-Authored-By: Alan Cruikshanks <alan.cruikshanks@gmail.com>
Cruikshanks
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://eaflood.atlassian.net/browse/RUBY-413
Add configuration and scheduling of the registration exemptions expiry job