Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ENV variable to setup magic link feature toggle #306

Merged
merged 1 commit into from
Aug 2, 2019
Merged

Use ENV variable to setup magic link feature toggle #306

merged 1 commit into from
Aug 2, 2019

Conversation

cintamani
Copy link
Contributor

No description provided.

@cintamani cintamani added the enhancement New feature or request label Aug 2, 2019
@cintamani cintamani self-assigned this Aug 2, 2019
@irisfaraway
Copy link
Member

@cintamani Should we also change the tests to stub the env var instead of the response from the feature toggle?

@cintamani
Copy link
Contributor Author

@irisfaraway I don't think that's necessary at all. All Feature toggles behaviour is well tested in the engine

@cintamani cintamani merged commit d0fcdee into master Aug 2, 2019
@cintamani cintamani deleted the ft-use-env branch August 2, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irisfaraway irisfaraway irisfaraway approved these changes

@Cruikshanks Cruikshanks Awaiting requested review from Cruikshanks

Assignees

@cintamani cintamani

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@cintamani @irisfaraway