Add ability to custom-parse attribute on Boxi serializer #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: https://eaflood.atlassian.net/browse/RUBY-556 We had the need to strip out newlines on multiline params such as `description` in the `addresses` table. To do so, I have used some methaprogramming to create parse methods for an attribute so that we can easely twick those value in the future.
cintamani
changed the title
|
Just shows what an ace developer @cintamani is! I forgot to say we have the issue in another field, but thanks to how the problem has been solved that won't be a problem ❤️ 🥇 😁 |
Cruikshanks
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: https://eaflood.atlassian.net/browse/RUBY-556
We had the need to strip out newlines on multiline params such as
descriptionin theaddressestable.To do so, I have used some methaprogramming to create parse methods for an attribute so that we can easely twick those value in the future.