Don't require active status to display renewal link #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to display the renew link when the registration is still in the renewal wndow. But we've spotted that the check to display the links requires the registration to still be active. However, some expired registrations could still be in the renewal window. In this case, the link would no longer display even when it should. This PR fixes this issue.
Decided not to use the registraton.state method here as that will return 'revoked' if anything is revoked. But we still want to be able to renew the non-revoked ones.
Cruikshanks
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to display the renew link when the registration is still in the renewal wndow. But we've spotted that the check to display the links requires the registration to still be active. However, some expired registrations could still be in the renewal window. In this case, the link would no longer display even when it should.
This PR fixes this issue.