Do not open renewals in new tab #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We missed it on code review, but was found later in QA. The renewal workflow for an NCCC user should follow the same as resuming a new registration, or editing an existing one. It should happen in the existing tab and not open a new one. Like resuming and editing, we continue to show the main menu in the header. The view confirmation feature opens the confirmation in PDF which does take the user out of the system. Hence we open that in a new tab, but we don't need to open resume, edit or renew in a new tab.
irisfaraway
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed it on code review, but was found later in QA. The renewal workflow for an NCCC user should follow the same as resuming a new registration, or editing an existing one. It should happen in the existing tab and not open a new one.
Like resuming and editing, we continue to show the main menu in the header. The view confirmation feature opens the confirmation in PDF which does take the user out of the system. Hence we open that in a new tab, but we don't need to open resume, edit or renew in a new tab.