Change AD confirm. letters job start time #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/RUBY-1161 The logic of the job is that it looks for AD registrations created that day. Any it finds it creates a PDF containing a copy of the confirmation letter for each one. Because of this it needs to run at the end of the day to pick up registrations created. The previous default start time of 00:55 means it was running at a time when there would never have been anything created. 22:35 seems to fit amongst the other jobs, and be towards the end of the day. It doesn't have to be at 23:59 because AD registrations have to be created by NCCC and they will have long finished for the day.
Cruikshanks
added
the
housekeeping
irisfaraway
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/RUBY-1161
The logic of the job is that it looks for AD registrations created that day. Any it finds it creates a PDF containing a copy of the confirmation letter for each one.
Because of this it needs to run at the end of the day to pick up registrations created. The previous default start time of 00:55 means it was running at a time when there would never have been anything created.
22:35 seems to fit amongst the other jobs, and be towards the end of the day. It doesn't have to be at 23:59 because AD registrations have to be created by NCCC and they will have long finished for the day.