Send letters to contacts with no email address #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| end | ||
|
|
||
| def find_email_variations(email_type) | ||
| WasteExemptionsEngine::Registration.where("#{email_type} ~* ? or #{email_type} ~* ? or #{email_type} ~* ?", WASTE_EXEMPTIONS_EMAIL_VARIATIONS, EXEMPTION_EMAIL_VARIATIONS, NCCC_EMAIL_VARIATIONS) |
Check notice
Code scanning / Brakeman
Possible SQL injection.
d-a-v-e
suggested changes
Aug 2, 2022
| # rubocop:disable Layout/LineLength | ||
| class RemoveNcccEmailService < ::WasteExemptionsEngine::BaseService | ||
|
|
||
| # https://rubular.com/r/LPHA79nxD5k2ff |
There was a problem hiding this comment.
this is really handy. (Make sure it is cleared on rubular.com once this is merged!)
There was a problem hiding this comment.
... in which case the comment should be deleted ....
| @@ -18,7 +16,7 @@ class Registration < ::WasteExemptionsEngine::ApplicationRecord | |||
|
|
|||
| scope :renewals, -> { where.not(referring_registration_id: nil) } | |||
|
|
|||
| scope :contact_email_is_not_nccc, -> { where.not(contact_email: NCCC_EMAIL) } | |||
| scope :contact_email_is_not_blank, -> { where.not(contact_email: nil) } | |||
There was a problem hiding this comment.
"blank" and "nil" are not the same - maybe rename this to contact_email_present and also check for empty string values?
| @@ -24,7 +24,7 @@ def ad_expiring_registrations | |||
| @_ad_expiring_registrations ||= lambda do | |||
| WasteExemptionsEngine::Registration | |||
| .order(:reference) | |||
| .where(contact_email: WasteExemptionsEngine.configuration.assisted_digital_email) | |||
| .where(contact_email: nil) | |||
There was a problem hiding this comment.
Might need to also check for empty strings
PaulDoyle-DEFRA
approved these changes
Aug 3, 2022
d-a-v-e
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/RUBY-1997
Here we have the changes to allow letters to be sent to registrations without an email address.
In WEX there are two emails address captured, applicant_email and contact_email.
These changes mean letters are sent to any emails that are nil value instead of the NCCC email address.