Replace ESLint with StandardJS #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-team#9 Defra's JavaScript standard is to use StandardJS for linting. We currently use ESLint, configured to Semi-Standard (ie. StandardJS with semicolons). For consistency, we should change this to the regular Standard rules, and replace ESLint with StandardJS while we're at it.
Jozzey
added
the
housekeeping
|
Sonarcloud is complaining because the unit test coverage is only 89.9%. Since I've just been replacing eslint with standard I'm not going to be sorting that out in this PR. |
StuAA78
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#9
Defra's JavaScript standard is to use StandardJS for linting. We currently use ESLint, configured to Semi-Standard (ie. StandardJS with semicolons). For consistency, we should change this to the regular Standard rules, and replace ESLint with StandardJS while we're at it.