Correctly set NODE_ENV #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-team#43 We are currently using `NODE_ENV` incorrectly; we set it to be the name of the specific environment (eg. `local`, `qa` etc.) when it should be more like the _type_ of environment (e.g. is it a dev environment, a production environment, etc.) This means that tools like pm2 aren't correctly picking up that we are running in a dev-like or prod-like environment and configuring accordingly. We, therefore, change how we use `NODE_ENV` to be the type of environment, with a separate `ENVIRONMENT` env var to set the actual environment (eg. `tst`, `pre` etc.)
Cruikshanks
added
the
housekeeping
This is the pattern we're using throughout the projects now using `ENVIRONMENT` to determine whether we are in `prd` or not. We also drop requiring dotenv directly. We've not needed it in other config.js files and we're pretty certain requiring it in the root index.js is all you need.
Looks like we were giving our local dev environments a boost when it came to connecting to PostgreSQL. We don't agree with making adjustments like this for local development. Plus, based on what we've seen so far we're not confident we should be playing with the default Postgres connection config at all. For now, we'll settle on just using the same config no matter the environment and leave changes to PG config to a wider review of the projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#43
We are currently using
NODE_ENVincorrectly; we set it to be the name of the specific environment (eg.local,qaetc.) when it should be more like the type of environment (e.g. is it a dev environment, a production environment, etc.)This means that tools like pm2 aren't correctly picking up that we are running in a dev-like or prod-like environment and configuring accordingly.
We, therefore, change how we use
NODE_ENVto be the type of environment, with a separateENVIRONMENTenv var to set the actual environment (eg.tst,preetc.)