Remove verbose from db migrate commands #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEFRA/water-abstraction-team#65 We needed to add a large data migration to fix an issue in . The fix worked but it broke CI. GitHub actions started erroring when the migrations ran with ##[error]stderr maxBuffer length exceeded. Unlike locally, where only the latest migrations are run, in CI all migrations are run all the time and our 2.5k SQL script (馃槼 馃榿 ) was obviously the straw that broke the camel's back. We realised that so much was outputting because all our migration scripts have the --verbose flag set. When we removed it in this case, the problem was solved. We don't need to see it, and it might avoid the same problem from happening to other repos. So, this issue is about going through the repos and removing --verbose from any migrate commands.
Jozzey
added
the
housekeeping
Cruikshanks
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFRA/water-abstraction-team#65
We needed to add a large data migration to fix an issue. The fix worked but it broke CI. GitHub actions started erroring when the migrations ran with
##[error]stderr maxBuffer length exceeded.Unlike locally, where only the latest migrations are run, in CI all migrations are run all the time and our 2.5k SQL script (馃槼 馃榿 ) was obviously the straw that broke the camel's back.
We realised that so much was outputting because all our migration scripts have the
--verboseflag set. When we removed it in this case, the problem was solved.We don't need to see it, and it might avoid the same problem from happening to other repos. So, this issue is about going through the repos and removing
--verbosefrom any migrate commands.