Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Node 20 #996

Merged
merged 2 commits into from Sep 23, 2023
Merged

Upgrade to Node 20 #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fc2996
Upgrade to Node 20
Cruikshanks Sep 23, 2023
efb8c69
Simplify node install in CI
Cruikshanks Sep 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 1 addition & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -50,18 +50,10 @@ jobs:
run: |
! grep -R 'experiment.only(\|test.only(' test

# Our projects use .nvmrc files to specify the node version to use. We can read and then output it as the result
# this step. Subsequent steps can then access the value
- name: Read Node version
run: echo "{NVMRC}={cat .nvmrc}" >> $GITHUB_OUTPUT
# Give the step an ID to make it easier to refer to
id: nvm

# Gets the version to use by referring to the previous step
- name: Install Node
uses: actions/setup-node@v3
with:
node-version: "${{ steps.nvm.outputs.NVMRC }}"
node-version-file: ".nvmrc"

# Speeds up workflows by reading the node modules from cache. Obviously you need to run it at least once, and the
# cache will be updated should the package-lock.json file change
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
@@ -1 +1 @@
v14.19.1
20