Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No matching tag highlighted if we use php inside the tag #172

Closed
kanlukasz opened this issue Oct 15, 2022 · 4 comments
Closed

No matching tag highlighted if we use php inside the tag #172

kanlukasz opened this issue Oct 15, 2022 · 4 comments
Assignees

Comments

@kanlukasz
Copy link

kanlukasz commented Oct 15, 2022

Video gif example:

Animation2

Note:

As you can see at the beginning of the video, all tags are properly matched / highlighted
But after using php inside a tag, the </section> tag does not highlight a match

Environment for tests:

  • VsCode Version: 1.72.2
  • PHP Tools v1.18.10878 Pre-Release
  • OS Name: Microsoft Windows 11 Pro
  • OS Version: 10.0.22621 N/A Build 22621

VSCode settings:

{
    "workbench.colorTheme": "Darcula",
    "php.suggest.basic": false,
    "php.validate.enable": false,
    "emmet.excludeLanguages": [
        "markdown",
        "php"
    ],
    "php.problems.exclude": {
        "wp-admin/": true,
        "wp-includes/": true,
        "wp-content/plugins/": true,
        "vendor/": true,
    },
    "php.codeLens.enabled": false
}
@jakubmisek
Copy link
Member

Thank you. We'll take a look at that, although it seems this is a bug in VSC HTML editor itself.

@jakubmisek

This comment was marked as off-topic.

@kanlukasz
Copy link
Author

although it seems this is a bug in VSC HTML editor itself.

But if I disable your addon it works fine.

@Miloslav Miloslav self-assigned this Dec 16, 2022
@Miloslav
Copy link
Member

This is fixed in the upcoming pre-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants