test(php81): fix Undefined array key errors in acceptance tests

DFAU · Jun 16, 2023 · f53be0e · f53be0e
1 parent 30ce56d
commit f53be0e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/Classes/Controller/JsonApiCollectionCommandController.php b/Classes/Controller/JsonApiCollectionCommandController.php
@@ -41,8 +41,8 @@ public function read(ServerRequestInterface $request): ResponseInterface
         $this->parseFieldsets($queryParams);
 
         $pageParams = $queryParams['page'] ?? [];
-        $currentCursor = $pageParams['cursor'];
-        $previousCursor = $pageParams['previous'];
+        $currentCursor = $pageParams['cursor'] ?? null;
+        $previousCursor = $pageParams['previous'] ?? null;
         $limit = $pageParams['limit'] ? (int) $pageParams['limit'] : 10;
 
         $filters = isset($queryParams['filter']) && \is_array($queryParams['filter']) ? $queryParams['filter'] : [];

diff --git a/Classes/Controller/JsonApiItemCommandController.php b/Classes/Controller/JsonApiItemCommandController.php
@@ -53,7 +53,8 @@ public function read(ServerRequestInterface $request): ResponseInterface
 
         $resourceIdentifier = \urldecode($request->getAttribute('variables')['id'] ?: '');
 
-        $data = $this->fetchAndTransformData($resourceIdentifier, $request->getAttributes()['context']);
+        $context = $request->getAttributes()['context'] ?? null;
+        $data = $this->fetchAndTransformData($resourceIdentifier, $context);
 
         if (null === $data) {
             return new JsonResponse($data, 404, ['Content-Type' => 'application/vnd.api+json; charset=utf-8']);

diff --git a/Classes/IncludeHandler/TcaResourceIncludeHandler.php b/Classes/IncludeHandler/TcaResourceIncludeHandler.php
@@ -125,7 +125,7 @@ protected function buildTcaIncludes($tableName): array
 
                         break;
                     case 'group':
-                        if ('db' === $columnConfig['internal_type'] && !empty($columnConfig['allowed']) && false === \strpos($columnConfig['allowed'], ',')) {
+                        if ('db' === ($columnConfig['internal_type'] ?? null) && !empty($columnConfig['allowed']) && false === \strpos($columnConfig['allowed'], ',')) {
                             return \array_merge($columnConfig, [static::REFERENCE_TABLE_NAME => GeneralUtility::trimExplode(',', $columnConfig['allowed'], true)]);
                         }