Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/opening date event #502

Merged
merged 10 commits into from
Jul 2, 2024
Merged

Feature/opening date event #502

merged 10 commits into from
Jul 2, 2024

Conversation

dneed-nimble
Copy link
Contributor

No description provided.

@DrizzlyOwl
Copy link
Collaborator

Hi @dneed-nimble please mark this PR as ready to review once you have fixed the issues preventing the .NET build task from passing.

@DrizzlyOwl DrizzlyOwl marked this pull request as draft July 1, 2024 13:39
@dneed-nimble dneed-nimble marked this pull request as ready for review July 1, 2024 14:21
@DrizzlyOwl DrizzlyOwl added the work needed More work is needed before this PR can be merged label Jul 1, 2024
@dneed-nimble dneed-nimble removed the work needed More work is needed before this PR can be merged label Jul 2, 2024
@DrizzlyOwl
Copy link
Collaborator

@dneed-nimble are you happy to merge with the sonarcloud coverage issues?

@dneed-nimble dneed-nimble merged commit ce0aff5 into main Jul 2, 2024
3 checks passed
@dneed-nimble dneed-nimble deleted the feature/opening-date-event branch July 2, 2024 15:00
Copy link

sonarcloud bot commented Jul 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
49.5% Coverage on New Code (required ≥ 70%)
C Reliability Rating on New Code (required ≥ A)
61 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants