Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autocomplete for Other UK qualifications #3315

Merged
merged 1 commit into from Nov 4, 2020
Merged

Add autocomplete for Other UK qualifications #3315

merged 1 commit into from Nov 4, 2020

Conversation

malcolmbaig
Copy link
Contributor

Context

There are several kinds of qualification that we want to provide as
autocomplete options in this free text field.

Changes proposed in this pull request

  • Add the qualification names to a constant defined in an initializer
  • Make these names available in the markup via a data attribute
  • Add the Javascript to make the input field autocomplete

Guidance to review

Add Academic and other relevant qualifications in the review app and select 'Other UK qualification'. The input should autocomplete with all the values listed in the initializer.

Link to Trello card

https://trello.com/c/ae3gsJvA

Things to check

  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • API release notes have been updated if necessary
  • New environment variables have been added to the Azure config

@malcolmbaig
Add autocomplete for Other UK qualifications
0ade2fc 
There are several kinds of qualification that we want to provide as
autocomplete options in this free text field.

- Add the qualification names to a constant defined in an initializer
- Make these names available in the markup via a data attribute
- Add the Javascript to make the input field autocomplete
@tijmenb tijmenb temporarily deployed to apply-for-te-1780-autoc-t2uuns November 3, 2020 12:03 Inactive
@malcolmbaig malcolmbaig added the Candidate Candidate facing issue label Nov 3, 2020
stevehook
stevehook approved these changes Nov 3, 2020
View reviewed changes
Copy link
Collaborator

@stevehook stevehook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Review app is working.

@malcolmbaig malcolmbaig merged commit 3e897e3 into master Nov 4, 2020
@malcolmbaig malcolmbaig deleted the 1780-autocomplete-other-uk-quals branch November 4, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehook stevehook stevehook approved these changes

@paulrobertlloyd paulrobertlloyd paulrobertlloyd approved these changes

@tvararu tvararu Awaiting requested review from tvararu

Assignees
No one assigned
Labels
Candidate Candidate facing issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@malcolmbaig @stevehook @paulrobertlloyd @tijmenb