Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assets precompile stage #5271

Merged
merged 4 commits into from Aug 3, 2021
Merged

Remove assets precompile stage #5271

merged 4 commits into from Aug 3, 2021

Conversation

vigneshmsft
Copy link
Contributor

@vigneshmsft vigneshmsft commented Aug 1, 2021 •
edited

Context

Simplify the different stages in the Dockerfile

Changes proposed in this pull request

Remove separate stage for assets precompile and move it inside a different layer in the gems-node-modules stage.

Guidance to review

Link to Trello card

https://trello.com/c/6vdVY6PL/481-refactor-apply-docker-image

Things to check

  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • API release notes have been updated if necessary
  • Required environment variables have been updated added to the Azure KeyVault

@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 1, 2021 11:57 Inactive
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 1, 2021 12:08 Inactive
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 1, 2021 12:51 Inactive
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 1, 2021 13:01 Inactive
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 2, 2021 09:23 Inactive
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 2, 2021 09:38 Inactive
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 2, 2021 09:55 Inactive
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 2, 2021 10:01 Inactive
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 2, 2021 10:09 Inactive
saliceti
saliceti reviewed Aug 2, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
saliceti
saliceti reviewed Aug 2, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 2, 2021 11:41 Inactive
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 2, 2021 12:26 Inactive
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 2, 2021 12:35 Inactive
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 3, 2021 13:23 Inactive
@vigneshmsft vigneshmsft marked this pull request as ready for review August 3, 2021 13:27
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 3, 2021 13:27 Inactive
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 3, 2021 14:01 Inactive
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-refactor-d-gfulx0 August 3, 2021 14:09 Inactive
@vigneshmsft vigneshmsft merged commit ce766dc into main Aug 3, 2021
@vigneshmsft vigneshmsft deleted the refactor-docker-image branch August 3, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saliceti saliceti saliceti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vigneshmsft @saliceti @duncanjbrown