Wait polynomially longer rather than exponentially #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wait: :exponentially_longer` will actually wait polynomially longer and is therefore deprecated in Rails 7.1.0 https://api.rubyonrails.org/classes/ActiveJob/Exceptions/ClassMethods.html#method-i-retry_on
|
TIL! Thank you 🙏 |
|
Might need to skip for rails 6 if it doesn't have that option? |
|
Oh it's ok, I was doing a quick experiment to see how much of a pain upgrading NPQ and ECF would be 😅 There's no urgency from us here. |
|
Maybe you like my approach? #95 |
|
Closing because we are merging #95 which addresses the issue and also deals with Rails 6 test failures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 7.1.0
wait: :exponentially_longerwill actually wait polynomially longer and has been deprecated.