CST-1207: rectify mentor pools when a participant is rectified #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltello
force-pushed
the
CST-1207-ensure-that-mentor-pools-transfer-over-when-a-schools-gias-record-updates
branch
from
19bbd7e
to
d471f8c
Compare
|
Created review app at https://ecf-review-pr-2913.london.cloudapps.digital |
|
Smoke tests passed against the review app. |
app/models/school_mentor.rb
Outdated
| @@ -5,5 +5,6 @@ class SchoolMentor < ApplicationRecord | |||
| belongs_to :participant_profile, class_name: "ParticipantProfile::Mentor" | |||
| belongs_to :preferred_identity, class_name: "ParticipantIdentity" | |||
|
|
|||
| scope :by, ->(participant_profile) { where(participant_profile:) } | |||
There was a problem hiding this comment.
Not sure of the value of this as it is only a simple where(participant_profile:) and is a bit ambiguous, what if I want want to look up by school? I get it's adding a bit of sugar but it then also becomes something else to remember.
There was a problem hiding this comment.
Ok, code rewritten without the scope.
ltello
force-pushed
the
CST-1207-ensure-that-mentor-pools-transfer-over-when-a-schools-gias-record-updates
branch
from
d471f8c
to
ead966b
Compare
ltello
deleted the
CST-1207-ensure-that-mentor-pools-transfer-over-when-a-schools-gias-record-updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When a school gets closed their participants are moved to its successor but the mentor pools are left unchanged.
Changes proposed in this pull request
Rectify the mentor pools of the school and its successor so the entries are moved from one to the other.
Guidance to review