feat: add custom-data processing #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PsypherPunk
commented
Jun 21, 2024
for "default" and "default-with-user-defined-comparator-set" for now; "custom" to follow.
re-use existing comparator-set logic but skip any processing for all but the URN in question.
- add mappings for custom-data message to existing, pre-processed data; - add pre-processing steps for custom data; - update comparator-set/RAG processing to accommodate custom data.
- `run_id` is correct as per use; `year` _might_ the value used; - add tests for new messages; - omit `log.py` from coverage.
for "custom" data, only the financial information for the target URN need be persisted in the DB.
PsypherPunk
force-pushed
the
feature/213664/custom-data
branch
from
1dedb5c
to
b93678a
Compare
for custom-data runs, central-services values must be zero.
jrabbott
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
adds custom-data message processing.
AB#213664
Change proposed in this pull request
enum(stricter typing would be nice but there's no defined "default" message format…yet).target_urnis passed, mostly to reduce the impact of any future refactoring.Guidance to review
I've changed
yeartorun_idin a lot of places;yearlargely serves as a run-identifier for the default job and I'd ended up with a lot ofrun_id or yearlogic in places. However, I've largely left the existing pre-processing as-is.Checklist