Add contact details to provider #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvararu
approved these changes
Jan 7, 2019
benilovj
approved these changes
Jan 7, 2019
benilovj
previously requested changes
Jan 8, 2019
|
Also, I noticed this isn't being used: https://github.com/devmynd/jsonb_accessor Might be useful here, although still need to see if it'd handle the existing data (e.g. I don't think it supports nested data, do we have any?) |
misaka
previously requested changes
Jan 8, 2019
dankmitchell
force-pushed
the
provider-contact-details
branch
4 times, most recently
from
3996aa7
to
1a283ef
Compare
dankmitchell
force-pushed
the
provider-contact-details
branch
from
1a283ef
to
20291ad
Compare
dankmitchell
force-pushed
the
provider-contact-details
branch
from
3bf64ea
to
f084724
Compare
tvararu
approved these changes
Jan 9, 2019
benilovj
reviewed
Jan 9, 2019
| "postcode" => attrs["Postcode"] | ||
| } | ||
| else | ||
| attributes |
There was a problem hiding this comment.
This returns more than just the address, no?
There was a problem hiding this comment.
It does. It's not the tidiest, true, but the whole ordeal is a bit messy anyway. I'd be up for tidying it up in the future, I reckon we'll be revisiting this bit of code anyway.
|
It didn’t help that the provider attributes are a different “case” to the enrichment attributes I.e. address1 vs Address1. The enrichments definitely needs refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Providers endpoint
Changes proposed in this pull request
Add contact details i.e.
address1,address2,address3,address4,postcodeGuidance to review
/api/v1/providers