Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3422] Provider search can now include self #1374

Merged
merged 3 commits into from May 20, 2020
Merged

[3422] Provider search can now include self #1374

merged 3 commits into from May 20, 2020

Conversation

asmega
Copy link
Contributor

@asmega asmega commented May 20, 2020 •
edited

Context

Changes proposed in this pull request

  • on accredited provider search if the accredited provider has a course
    themselves that meets the criteria the accredited provider is returned
    in the results
  • previously only training providers would be considered

Guidance to review

  • Navigate to a provider with their own fee funded PE course eg 2AT
  • go to the index allocations page
  • should see yet to request repeat allocation

Checklist

  • Make sure all information from the Trello card is in here
  • Attach to Trello card
  • Rebased master
  • Cleaned commit history
  • Tested by running locally

@asmega
Copy link
Contributor Author

asmega commented May 20, 2020

Accredited bodies should be able to request PE allocations

@asmega asmega force-pushed the 3422-provider-search-includes-provider branch from 39e0fc5 to 0745e7a Compare May 20, 2020 11:52
@asmega
[3422] Provider search can now include self
fe7c73d 
- on accredited provider search if the accredited provider has a course
themselves that meets the criteria the accredited provider is returned
in the results
- previously only training providers would be considered
@asmega asmega force-pushed the 3422-provider-search-includes-provider branch from 0745e7a to fe7c73d Compare May 20, 2020 13:59
@DFE-Digital DFE-Digital deleted a comment from TobyRet May 20, 2020
@asmega asmega marked this pull request as ready for review May 20, 2020 14:28
@asmega asmega mentioned this pull request May 20, 2020
Merged
6 tasks
misaka
misaka approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@misaka misaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions for being clearer specs, but good to go overall.

asmega and others added 2 commits May 20, 2020 16:51
@asmega
Improve spec description
7e5bbf1 
Co-authored-by: Misha Gorodnitzky <michael.gorodnitzky@digital.education.gov.uk>
@asmega
Improve spec description
c8c1766 
Co-authored-by: Misha Gorodnitzky <michael.gorodnitzky@digital.education.gov.uk>
@asmega asmega merged commit 57c164f into master May 20, 2020
@asmega asmega deleted the 3422-provider-search-includes-provider branch May 20, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misaka misaka misaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asmega @misaka