Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEVA-1320] Additional copy for 401 unauth page #2138

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Conversation

alexbowen
Copy link
Contributor

%p= t('error_pages.unauthorised.text_html')
%ul.govuk-list.govuk-list--bullet
-t('error_pages.unauthorised.options').each do |li|
%li=li.html_safe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should work without the .html_safe

Copy link
Contributor Author

@alexbowen alexbowen Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately no because one option has html in it, and i thought this was the least hacky way to do it

@github-actions
Copy link

@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@alexbowen alexbowen merged commit a18165a into master Oct 14, 2020
@alexbowen alexbowen deleted the TEVA-1320-401-copy branch October 14, 2020 08:06
@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants