Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create design cards for guide pages #6956

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ddippolito
Copy link
Contributor

Trello card URL

https://trello.com/c/00OJTwz9/1059-redesign-jobseeker-hiring-staff-guides-links-into-cards

Changes in this PR:

Redesign jobseeker/hiring staff guides links into cards

Screenshots of UI changes:

Before

Screenshot 2024-07-12 at 16 57 35

After

Screenshot 2024-07-12 at 16 56 55

@ddippolito ddippolito force-pushed the create-design-cards-for-guide-pages branch 3 times, most recently from 9d026ce to f898f14 Compare July 12, 2024 16:07
Copy link

Review app deployed to https://teaching-vacancies-review-pr-6956.test.teacherservices.cloud on AKS

@@ -3,25 +3,27 @@ class MarkdownDocument

attr_reader :section, :subcategory, :post_name

def initialize(section, subcategory, post_name)
def initialize(section:, post_name:, subcategory: nil)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants