Skip to content
This repository has been archived by the owner on Mar 22, 2021. It is now read-only.

[doc] describe development environment #36

Closed
erikbgithub opened this issue Mar 4, 2013 · 5 comments
Closed

[doc] describe development environment #36

erikbgithub opened this issue Mar 4, 2013 · 5 comments
Assignees

Comments

@erikbgithub
Copy link
Contributor

Problem

The current contributing.rst is merely a list of dos and don'ts. Neither does anybody want to read that nor does it really tell people how to develop for MONK. I feel that this page should mostly be a guide going step by step through installing the system requirements, creating the development environment, running the test suite and making a little change to MONK. Only in the end should be the rules and details for people who want to dive in more deeply or iif the team needs some arguments for decision making. But those cases are rare.

Solution

Create tutorial with git, virtualenv, test suite and use this issue as example for making a change to MONK.

Notes

  • For reviewers:
    • the spell checking will be done after @toang is back from her holidays

    • to close this task you need to build the docs without warnings and errors with

      # somewhere in your filesystem
      somewhere$ git clone -b f-docs-devenv git@github.com:DFE/MONK
      somewhere$ cd MONK
      MONK$ virtualenv .
      MONK$ . bin/activate
      (MONK)MONK$ pip install sphinx
      ...
      (MONK)MONK$ python setup.py develop
      ...
      (MONK)MONK$ cd doc
      (MONK)doc$ make html
      (MONK)doc$ chromium-browser build/html/contributing.html
      # read if you can understand it in most cases -> ACK
      (MONK)doc$ deactivate
      doc$
      
  • changes will be added with f-docs-devenv
@ghost ghost assigned erikbgithub Mar 4, 2013
erikbgithub added a commit that referenced this issue May 14, 2013
See Github Issue #36.

Signed-off-by: Erik Bernoth <erik.bernoth@gmail.com>
erikbgithub added a commit that referenced this issue May 14, 2013
See Github Issue #36.

Signed-off-by: Erik Bernoth <erik.bernoth@gmail.com>
erikbgithub added a commit that referenced this issue May 15, 2013
See Github Issue #36.

Signed-off-by: Erik Bernoth <erik.bernoth@gmail.com>
@erikbgithub
Copy link
Contributor Author

Changed the topic to reflect the real problem. It's mostly not about adding more lists with even more information. It's about giving the new user a guided tour through the dev process, that he can start to work more efficiently.

erikbgithub added a commit that referenced this issue May 21, 2013
See Github Issue #36.

Signed-off-by: Erik Bernoth <erik.bernoth@gmail.com>
erikbgithub added a commit that referenced this issue May 22, 2013
See Github Issue #36.

Signed-off-by: Erik Bernoth <erik.bernoth@gmail.com>
erikbgithub added a commit that referenced this issue May 23, 2013
Following the recent changes in the development environment, adding support for
virtualenv, depencies and so on, it was a good time to also rewrite the
contributing page. A tutorial was added, which walks through the creation of a
development environment and the creation of this task.

Reviewers should add themselves to the tutorial section which talks about
Acked-bys, to complete the tutorial (there's a TODO for it at the right place)
and they might also explain something about their review process.

See Github Issue #36.

Signed-off-by: Erik Bernoth <erik.bernoth@gmail.com>
@erikbgithub
Copy link
Contributor Author

can be reviewed.

erikbgithub added a commit that referenced this issue May 27, 2013
Following the recent changes in the development environment, adding support for
virtualenv, depencies and so on, it was a good time to also rewrite the
contributing page. A tutorial was added, which walks through the creation of a
development environment and the creation of this task.

Reviewers should add themselves to the tutorial section which talks about
Acked-bys, to complete the tutorial (there's a TODO for it at the right place)
and they might also explain something about their review process.

See Github Issue #36.

Signed-off-by: Erik Bernoth <erik.bernoth@gmail.com>
@binschek
Copy link
Member

"make html" does not work. 👎

(MONK)[binschek@cd-400-548 doc]$ make html
rm -rf build/html/*
rm -rf source/monk_tf.rst
rm -rf source/modules.rst
sphinx-apidoc -o source ../src/monk_tf
../src/monk_tf is not a directory.
make: *** [apidoc] Error 1
(MONK)[binschek@cd-400-548 doc]$ 

erikbgithub added a commit that referenced this issue May 28, 2013
Following the recent changes in the development environment, adding support for
virtualenv, depencies and so on, it was a good time to also rewrite the
contributing page. A tutorial was added, which walks through the creation of a
development environment and the creation of this task.

Reviewers should add themselves to the tutorial section which talks about
Acked-bys, to complete the tutorial (there's a TODO for it at the right place)
and they might also explain something about their review process.

See Github Issue #36.

Signed-off-by: Erik Bernoth <erik.bernoth@gmail.com>
@binschek
Copy link
Member

ACK

1 similar comment
@DfePeterWinkler
Copy link
Contributor

ACK

erikbgithub added a commit that referenced this issue May 28, 2013
Following the recent changes in the development environment, adding support for
virtualenv, depencies and so on, it was a good time to also rewrite the
contributing page. A tutorial was added, which walks through the creation of a
development environment and the creation of this task.

Reviewers should add themselves to the tutorial section which talks about
Acked-bys, to complete the tutorial (there's a TODO for it at the right place)
and they might also explain something about their review process.

See Github Issue #36.

Signed-off-by: Erik Bernoth <erik.bernoth@gmail.com>
Acked-by: Eik Binschek <binschek@dresearch-fe.de>
Acked-by: Peter Winkler <winkler@dresearch-fe.de>
erikbgithub added a commit that referenced this issue May 28, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants