Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pupil-api: Update dependencies #1796

Merged
merged 5 commits into from
Jan 12, 2021
Merged

Pupil-api: Update dependencies #1796

merged 5 commits into from
Jan 12, 2021

Conversation

jon-shipley
Copy link
Collaborator

Security fix

Update dependencies
Security fix: bump node-fetch to 2.6.1

@jon-shipley jon-shipley added the CI Enabled Travis will only build PRs with this label assigned label Jan 7, 2021
@jon-shipley jon-shipley self-assigned this Jan 7, 2021
Copy link
Collaborator

@GuyHarwood GuyHarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jon-shipley
Copy link
Collaborator Author

@GuyHarwood

Please note this PR changes the behaviour of the X-XSS-Protection response header because helmet has changed, as has the wider web (e.g. google.com)

Previous behaviour was to set

X-XSS-Protection to 1; mode=block

The new behaviour is to set:

X-XSS-Protection to 0

This appears to be because setting it to 1; block did not work as expected as t opened up a side-channel attack. Given that most attacks are in the more advanced spectrum, this seems more preferable than to set it to block which only protects against trivial attacks, but opens up side-channel attacks.

Helmet Changelog: https://github.com/helmetjs/helmet/blob/main/CHANGELOG.md
This issue changing the behaviour: helmetjs/helmet#230
MDN documentation: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-XSS-Protection

@activemq - should this new behaviour be approved by @GuyHarwood we will need to update the corresponding test.

@GuyHarwood
Copy link
Collaborator

@jon-shipley sounds like the best approach to me 👍🏼

@GuyHarwood GuyHarwood merged commit 37402d6 into master Jan 12, 2021
@GuyHarwood GuyHarwood deleted the chore/pupil-api-deps branch January 12, 2021 10:51
jon-shipley added a commit that referenced this pull request Jan 13, 2021
* master:
  feature/45099 - fixes for the pipeline (#1801)
  [admin] bug fix: only count visible pupils (#1799)
  Pupil-api: Update dependencies (#1796)

# Conflicts:
#	admin/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants