Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: new types: std::mutex, std::condition_variable, size_t, ssize_t, unsigned long #622

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

lethosor
Copy link
Member

@lethosor lethosor commented Aug 2, 2023

Partial implementation of DFHack/dfhack#3427

Needed to align enabler on Linux

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

The sizes of the following types have changed in this pull request. Please verify that this is intentional. Note that renamed types are not currently detected and will also be listed here.

Type Platform Previous size New size (this PR) Change
enabler linux32 904 664 -240
enabler linux64 1208 1016 -192
gamest linux32 29556 29552 -4
main_interface_settings linux32 876 872 -4
unit linux32 3812 3808 -4
widget_tabs linux32 92 88 -4

This is an automated comment. Please leave a reply if you think that the above information is incorrect.

@myk002
Copy link
Member

myk002 commented Aug 2, 2023

In chat, you said that enabler was 1008 bytes. Do you know where the last bit of difference is coming from?

@lethosor
Copy link
Member Author

lethosor commented Aug 2, 2023

I was still working on figuring that out. For reference, it looks like these two fields have been deleted in the most recent build I have: https://github.com/Putnam3145/Dwarf-Fortress--libgraphics--/blob/26fd0f49270aea488b8673d49e605c2b783d4c25/g_src/enabler.h#L560C31-L561

(also a uint32 needed to change to a long... actually, an unsigned long, which I should probably add support for)

@lethosor
Copy link
Member Author

lethosor commented Aug 2, 2023

Refreshing to hopefully pick up 7f859ce

@lethosor lethosor closed this Aug 2, 2023
@lethosor lethosor reopened this Aug 2, 2023
@lethosor lethosor changed the title codegen: new types: std::mutex, std::condition_variable, size_t, ssize_t codegen: new types: std::mutex, std::condition_variable, size_t, ssize_t, unsigned long Aug 2, 2023
@lethosor lethosor merged commit c87d226 into DFHack:master Aug 3, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants