WIP filter reports out from announcelist screen #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lethosor
reviewed
Feb 27, 2020
| -- always be the last one. | ||
| for i = #vec-1,0,-1 do | ||
| if vec[i].id == id then | ||
| -- TODO: do we need to set `world.status.display_timer = 0` here? |
There was a problem hiding this comment.
You probably want to set display_timer to 0 when the last report is one that shouldn't be displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script filters reports out from announcelist screen (
a), which doesn't prevent them fromentering gamelog.txt.
Example usage: in announcements.txt add
D_Dto regular and combat conversations like this.Restart the game.
Now there are conversations in the reports, which is a bit too much. Luckily,
this script deals with exact that problem (
filter-reports REGULAR_CONVERSATION CONFLICT_CONVERSATION).And finally you would need another tool to do something about all the stuff
that's in the gamelog now. Like Soundsense or Announcement Window. But the filters are missing as of now.
Alternative is adapting it_was_inevitable, maybe both.
Marked WIP because of missing filters, the script itself is functioning.