[suspendmanager] Detect and protect dead end constructions #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you made any progress on this? I'd like to get it into the next beta release if possible |
|
Unfortunately no, I got a bit discouraged by not managing to find a clean approach... I'll attempt to get back on it this week-end to get it on a mergeable state, maybe off by default with a «experimental» warning in the UI if it feels too risky? |
|
That's why we have the beta branch on Steam. We can ask for testing and feedback there before we push a new public stable build. |
plule
force-pushed
the
suspendmanager-deadend-detection
branch
from
f9d103c
to
39b308f
Compare
plule
force-pushed
the
suspendmanager-deadend-detection
branch
from
39b308f
to
d080e3e
Compare
plule
force-pushed
the
suspendmanager-deadend-detection
branch
from
d080e3e
to
0a0d036
Compare
|
After using it for a few days there are a lot of case where it did not behave correctly and I had to disable it... putting back in draft |
|
closing - will reopen after #721 that's just focused on the class refacto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DFHack/dfhack#3049 and DFHack/dfhack#3157
Replace the suspendmanager blocking detection. This new approach explore groups of connected construction jobs, and suspend corridors that would prevent accessing a deadend or the cluster entirely.
This approach handles many more situations, the most important being the issues linked above. It also behaves better for filling area, which was mentioned on discord.
It still have some short-coming, such as interior corridors in a big cluster not being suspended, and the general algorithm feeling more complicated than it should be but all my attempt to simplify the general logic lead to many blocking points...
Two situations where the previous approach would mostly fail, but are now well handled:
Two-z walls where dwarves must build the walls one by one:
Area filling: