Added ability to extermiante all wild creatures #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hiranus ...and also a typo in your title; are you sure you want it out there like that? |
myk002
reviewed
Feb 25, 2024
| @@ -30,6 +30,10 @@ Examples | |||
| Kill the ravens flying around the map (but only the male ones). | |||
| ``exterminate GOBLIN --method magma --only-visible`` | |||
| Kill all visible, hostile goblins on the map by boiling them in magma. | |||
| ``exterminate all`` | |||
| Kill all wild creatures. | |||
There was a problem hiding this comment.
Suggested change
| Kill all wild creatures. | |
| Kill all non-friendly creatures. |
| ``exterminate all`` | ||
| Kill all wild creatures. | ||
| ``exterminate all:FEMALE`` | ||
| Kill all wild female creatures. |
There was a problem hiding this comment.
Suggested change
| Kill all wild female creatures. | |
| Kill all non-friendly female creatures. |
| selected_caste = tokens[2] | ||
| end | ||
|
|
||
| for _, unit in pairs(df.global.world.units.active) do |
There was a problem hiding this comment.
Suggested change
| for _, unit in pairs(df.global.world.units.active) do | |
| for _, unit in ipairs(df.global.world.units.active) do |
Comment on lines
+185
to
+190
| local selected_caste = nil | ||
|
|
||
| if string.find(positionals[1], ':') then | ||
| local tokens = positionals[1]:split(':') | ||
| selected_caste = tokens[2] | ||
| end |
There was a problem hiding this comment.
Suggested change
| local selected_caste = nil | |
| if string.find(positionals[1], ':') then | |
| local tokens = positionals[1]:split(':') | |
| selected_caste = tokens[2] | |
| end | |
| local selected_caste = positionals[1]:split(':')[2] |
There was a problem hiding this comment.
I realize this was copied from the section below, but since you don't care about the "race" (all) here, it can be simplified
|
Also needs changelog entry, please |
|
Ping on this; have you had a chance to read the review comments? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to exterminate all wild creatures with single command