Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on trade caravan #54

Closed
jmdejong opened this issue Oct 8, 2017 · 15 comments

Comments

@jmdejong
Copy link

commented Oct 8, 2017

When trying to view tiles with a trade wagon, both stonesense and dwarffortress become unresponsive. The dwarf fortress window stops updating the screen.
The dfhack console still works.

No error message is generated.

Example save file with a trade caravan in the fortress: https://github.com/tildetown/tilde-df/tree/b2056a945ee5f6adbeb5a186e0cadc5cb0784d2b

I'm running this on 64bit Archlinux. I have tried both the AUR version (dfhack 0.43.05-r1), and a manual install of dfhack 0.43.05-r2.

I strongly suspect that it's the wagon causing the crash, but it's possible that some other part of the caravan is the cause.

@Vislar

This comment has been minimized.

Copy link

commented Oct 20, 2017

Seconded,
Stonesense seems to hate trade wagons. Even though I use 0.43.03 32bit because of my older system at the moment, it seems like this bug applies to newer versions as well. Which is unfortunate.

@FalcoGer

This comment has been minimized.

Copy link

commented Nov 16, 2017

This is happening to me also.
Running Ubuntu 16.04 LST 64 bit with DF 0.43.05 + twbt + DFHack 0.43.05r2 installed with LNP.
DF just crashes along with dfhack and ssense when trying to view a tile that has a wagon. took me some time to figure it out.
no error message is given for anything.

@JapaMala

This comment has been minimized.

Copy link
Member

commented Dec 1, 2017

I'll have a look and see what I can manage.

@JapaMala JapaMala self-assigned this Dec 1, 2017

@NutchapolSal

This comment has been minimized.

Copy link

commented Mar 9, 2018

This is even worse on Windows 10 64bit (DF 0.44.05 + DFHack 0.44.05-r2)
Instantly crashes when a trade wagon exists, No "Not responding", and bringing DF down with it(and destroying all progress after the last save)

At least I can now go back to my first fort after thinking DF can't handle it anymore and then making another fort

@Eilmanx

This comment has been minimized.

Copy link

commented May 6, 2018

Using DF version 44.09 on Windows 10.

Bug seems to be still there there. Trade caravan comes and crashes the game. When I used to play it in windows 7 system, I could manipulate Stonesense camera away from trading cart and evade crash that way. But now it doesn't work anymore, it crashes immediately when caravan enters to the map area. I tried to turn on/off all possible features in Stonsesense, but nothing helps. If someone could remove possibility to load trade caravans altogether in code, it might help, I have no better ideas.

@Random-txt

This comment has been minimized.

Copy link

commented Jun 23, 2018

has this been resolved? My game crashes right after i hear the trade music from soundsense. I am guessing that it is the trader who caused my crash.
Do i start a new game or, is there a solution?

@lethosor

This comment has been minimized.

Copy link
Member

commented Jun 24, 2018

Can't you just run without stonesense?

@mianxiu

This comment has been minimized.

Copy link

commented Oct 16, 2018

I' has a same problem too.

@theicewolf23

This comment has been minimized.

Copy link

commented Dec 23, 2018

I have the same problem.
I use PeridexisErrant's Starter Pack (64bit) version 0.44.12-r04.
It happened on version version 0.44.12-r03 as well.
It happens repeatedly and consistently. The game is automatically paused. Whenever I move the screen to the newly arrived caravan the game and stonesense crashes, the DF and stonesense windows close and I lose the unsaved progress. The stderr.log in the directory Dwarf Fortress 0.44.12 reports nothing of the crash. What information do you need from me to fix this issue ?

@napagokc

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Absolutely the same as @theicewolf23 described.
Windows 7 x64, latest Masterwork pack (2.6.0.0 - DF 0.44.12, DFHack 0.44.12-r2 (release) on x86_64).

@lethosor

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

What information do you need from me to fix this issue ?

Since it seems to be pretty reproducible, it's unlikely to be specific to anyone's system. Really the only thing that can be provided is a save, which was provided in the first post. Error logs rarely contain useful information about crashes.

(Stonesense has historically been unstable on my primary system(s) so I can't fix this myself.)

@napagokc

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

Just in case please have also my save, hope it'll help at least a bit :)
https://drive.google.com/open?id=1QfsB5Eazfa7U0tgP_6Pr6hT6pr-GwsaO

@lethosor lethosor added the Crash label Jul 10, 2019

@napagokc

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

Sooo.... I've been mighty curious and debugged the thing and found out that there's a nullptr exception at line 532 in Creatures.cpp. Simple check did the trick:

if(source->status.current_soul != nullptr) {
    furball.stress_level = source->status.current_soul->personality.stress_level;
}

Apparently wagon has no soul :)
But I noticed that it is displayed with mere "W" where it has the center.
screenshot
Since I never saw it in life before - is it like that by design?

@lethosor

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

That's definitely a likely cause. I'm honestly surprised that hadn't come up before - many creatures don't have souls, and that change (9c9d8a5) was introduced in 2014. I'll make that fix and hopefully it works.

I'm guessing there probably isn't a wagon sprite.

@lethosor lethosor assigned napagokc and lethosor and unassigned JapaMala Jul 10, 2019

@lethosor lethosor closed this in 03e9647 Jul 10, 2019

lethosor added a commit to DFHack/dfhack that referenced this issue Jul 10, 2019

@lethosor lethosor added this to To do in 0.44.12-r3 via automation Jul 10, 2019

@lethosor lethosor moved this from To do to Done in 0.44.12-r3 Jul 10, 2019

@lethosor

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

I have posted builds with that fix for the systems that were mentioned above at https://files.dfhack.org/190710000/. Let me know if that works or if you would like builds for other systems. To upgrade stonesense:

  • Copy hack/plugins/stonesense.plug.* from the zip to hack/plugins in your dfhack installation (it should overwrite the copy of stonesense that's already there)
  • (Probably optional:) Copy the stonesense folder over the existing stonesense folder (I don't think it has changed at all since 0.44.12-r2, though, so you can probably skip this)

cc: @jmdejong @Vislar @FalcoGer @NutchapolSal @Eilmanx @Random-txt @mianxiu @theicewolf23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
You can’t perform that action at this time.