OrcLib: Temporary: improve temporary folder deletion

src/OrcLib/Temporary.cpp

@@ -12,6 +12,7 @@
 
 #include "ParameterCheck.h"
 #include "SecurityDescriptor.h"
+#include "Output/Text/Fmt/error_code.h"
 
 #include <boost/scope_exit.hpp>
 
@@ -606,16 +607,18 @@ HRESULT ORCLIB_API Orc::UtilDeleteTemporaryFile(LPCWSTR pszPath)
 
 HRESULT ORCLIB_API Orc::UtilDeleteTemporaryDirectory(const std::filesystem::path& path)
 {
-    for (auto& p : std::filesystem::directory_iterator(path))
+    for (auto& p : std::filesystem::recursive_directory_iterator(path))
     {
         if (auto hr = UtilDeleteTemporaryFile(p.path()); FAILED(hr))
             Log::Error(L"Failed to delete temp file {} (hr:{:#010x})", p.path(), hr);
     }
 
-    if (!RemoveDirectory(path.c_str()))
+    std::error_code ec;
+    std::filesystem::remove_all(path, ec);
+    if (ec)
     {
-        Log::Error(L"Failed to delete temp dir {} (hr:{:#010x})", path, HRESULT_FROM_WIN32(GetLastError()));
-        return HRESULT_FROM_WIN32(GetLastError());
+        Log::Error(L"Failed to delete temp dir {} (ec:{})", path, ec);
+        return HRESULT_FROM_WIN32(ec.value());
     }
     return S_OK;
 }