Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front: Using RTK types/functions for most cases #3579

Merged
merged 5 commits into from
Apr 3, 2023
Merged

Front: Using RTK types/functions for most cases #3579

merged 5 commits into from
Apr 3, 2023

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Mar 17, 2023

See #3469

@sim51 sim51 requested review from a team as code owners March 17, 2023 11:17
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #3579 (38fa3fc) into dev (8829ac7) will increase coverage by 0.90%.
The diff coverage is 45.40%.

@@             Coverage Diff              @@
##                dev    #3579      +/-   ##
============================================
+ Coverage     68.88%   69.79%   +0.90%     
  Complexity     2002     2002              
============================================
  Files           439      438       -1     
  Lines         22346    21896     -450     
  Branches       1658     1658              
============================================
- Hits          15394    15282     -112     
+ Misses         6157     5819     -338     
  Partials        795      795              
Flag Coverage Δ
editoast 75.30% <ø> (ø)
front 58.99% <45.40%> (+1.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/reducers/editor.ts 42.56% <13.33%> (-9.82%) ⬇️
front/src/applications/editor/data/api.ts 29.65% <41.02%> (-2.23%) ⬇️
front/src/applications/editor/data/utils.ts 35.93% <46.00%> (+3.54%) ⬆️
front/src/reducers/osrdconf/index.ts 33.99% <61.53%> (+0.35%) ⬆️
front/src/common/api/osrdEditoastApi.ts 90.83% <100.00%> (-0.14%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nicolaswurtz nicolaswurtz added the area:front Work on Standard OSRD Interface modules label Mar 17, 2023
jacomyal
jacomyal previously approved these changes Mar 17, 2023
@sim51 sim51 requested a review from flomonster March 18, 2023 05:48
@sim51 sim51 added the module:infra-editor Infra Edition label Mar 20, 2023
@sim51 sim51 force-pushed the bsi/editor-rtk branch 2 times, most recently from a8ea9ff to e23a308 Compare March 20, 2023 09:06
@sim51 sim51 enabled auto-merge (rebase) March 21, 2023 10:23
flomonster
flomonster previously approved these changes Mar 24, 2023
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only checked the openapi

@sim51 sim51 merged commit 4661682 into dev Apr 3, 2023
@sim51 sim51 deleted the bsi/editor-rtk branch April 3, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules module:infra-editor Infra Edition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants