core: envelope: adapt for mareco #469

multun · 2022-01-09T22:27:46Z

No description provided.

Fixes #464

codecov · 2022-01-12T17:18:26Z

Codecov Report

Merging #469 (b394cf6) into dev (f8327f4) will increase coverage by 0.35%.
The diff coverage is 79.56%.

@@             Coverage Diff              @@
##                dev     #469      +/-   ##
============================================
+ Coverage     67.65%   68.00%   +0.35%     
- Complexity     1914     1985      +71     
============================================
  Files           310      312       +2     
  Lines         10047    10231     +184     
  Branches       1374     1404      +30     
============================================
+ Hits           6797     6958     +161     
- Misses         2634     2643       +9     
- Partials        616      630      +14

Flag	Coverage Δ
core	`68.00% <79.56%> (+0.35%)`	⬆️
unittests	`68.00% <79.56%> (+0.35%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...main/java/fr/sncf/osrd/envelope/EnvelopeDebug.java	`0.00% <0.00%> (ø)`
...sncf/osrd/envelope/OverlayEnvelopePartBuilder.java	`84.73% <73.33%> (-1.22%)`	⬇️
.../src/main/java/fr/sncf/osrd/envelope/Envelope.java	`84.03% <78.18%> (-2.74%)`	⬇️
...ain/java/fr/sncf/osrd/envelope/EnvelopeCursor.java	`79.32% <81.39%> (+4.14%)`	⬆️
...in/java/fr/sncf/osrd/envelope/EnvelopePhysics.java	`93.33% <85.71%> (-1.67%)`	⬇️
...n/java/fr/sncf/osrd/envelope/EnvelopeSpeedCap.java	`88.88% <88.88%> (ø)`
.../fr/sncf/osrd/envelope/OverlayEnvelopeBuilder.java	`89.13% <92.85%> (+2.28%)`	⬆️
.../main/java/fr/sncf/osrd/envelope/EnvelopePart.java	`78.85% <94.73%> (+11.49%)`	⬆️
.../src/main/java/fr/sncf/osrd/utils/CompareSign.java	`100.00% <100.00%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8327f4...b394cf6. Read the comment docs.

core/src/main/java/fr/sncf/osrd/envelope/EnvelopeCursor.java

core/src/main/java/fr/sncf/osrd/envelope/EnvelopePart.java

core/src/main/java/fr/sncf/osrd/envelope/EnvelopeSpeedCap.java

core/src/main/java/fr/sncf/osrd/envelope/OverlayEnvelopeBuilder.java

core/src/test/java/fr/sncf/osrd/envelope/EnvelopeSpeedCapTest.java

axrolld

Thank you Santa for this wishlist. Only a few checks remain, then we'll be able to use all of this.

* core: envelope: adapt for mareco Fixes #464 * core: envelope: add EnvelopeSpeedCap and refactor * core: envelope: add the ability to plot multiple envelopes * core: envelopes: fix various review comments

core: envelope: adapt for mareco

d536c45

Fixes #464

multun force-pushed the envelopes-for-mareco branch from 1544819 to ffa5499 Compare January 11, 2022 08:31

core: envelope: add EnvelopeSpeedCap and refactor

1434938

multun force-pushed the envelopes-for-mareco branch from ffa5499 to 1434938 Compare January 12, 2022 17:15

multun changed the title ~~core: envelope: WIP adapt for mareco~~ core: envelope: adapt for mareco Jan 13, 2022

multun marked this pull request as ready for review January 13, 2022 08:59

multun requested review from a team January 13, 2022 08:59